gcc: if langAda then propagate brokenness from gnatboot #173813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
mentioned this pull request
|
I don't think we really need this; ideally GNAT never regresses again. A fix for the GNAT 6 problem is in staging, the thing we should do is search for a replacement for gnatboot: Gentoo doesn't use it anymore and has even deleted it from its mirrors. I have no clue what debian does (maybe the previous version of the package?). Gentoo uses gnat-community / gnat-gpl from AdaCore, but I don't think their bindist useable for our purposes, really: It requires running some kind of installer that depends on a bunch of libraries, including X11 and dbus – so this would be a painful bootstrapping chain. I wonder if you may have any insight? |
|
Ok. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit causes
gcc${version}.meta.brokento become true iflangAdaandgnatboot.meta.broken. This means that marking any part of the gnatboot chain broken will propagate the broken attribute through the chain of gnat6,gnat9,gnat10,gnat11,gnat12 builds.This commit does not mark any packages as broken. It simply automates the propagation of brokenness so downstream packages can respond intelligently (e.g. #173808)
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)